Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback to a commit hash in codesign.sh #5889

Merged
1 commit merged into from
Mar 3, 2024

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Feb 21, 2024

Issue being fixed or feature implemented

We don't use tags in https://github.com/dashpay/dash-detached-sigs repo, we use branches so git describe fails...

What was done?

Add --always option to fallback to commit hash. Could do

git_head_version() {
    git -C "$1" rev-parse --short=12 HEAD`
}

instead but using describe allows us to start using tags one day with no additional patches.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20.1 milestone Feb 21, 2024
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can't test, re-install guix now :(

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta closed this pull request by merging all changes into dashpay:develop in 533d82c Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants